| 03:13.08 | *** join/#catroid infobot (~infobot@rikers.org) |
| 03:13.08 | *** topic/#catroid is Official #catroid channel. Logs available at http://infobot.rikers.org/%23catroid/ |
| 08:53.09 | *** join/#catroid atermenji (~atermenji@satellite.donapex.net) |
| 09:11.31 | *** join/#catroid ptreitler (~pete@178.188.56.46) |
| 13:27.54 | atermenji | aried3r ptreitler anybody here? |
| 13:42.24 | ptreitler | yes |
| 13:44.41 | ptreitler | ...but just about to leave; heading home from work. Will catch you in ~half an hour |
| 13:44.50 | *** part/#catroid ptreitler (~pete@178.188.56.46) |
| 14:14.44 | *** join/#catroid ptreitler (~ptreitler@80-123-28-126.adsl.highway.telekom.at) |
| 14:14.56 | ptreitler | back |
| 14:19.47 | atermenji | hi Peter |
| 14:20.06 | atermenji | it seems that all tests from UItestProject are passing now |
| 14:20.33 | atermenji | http://catroidtestserver.ist.tugraz.at:8080/job/GSoC-2012-Artur/32/ |
| 14:20.41 | atermenji | here is my latest test result |
| 14:20.58 | atermenji | there are 3 failures in UItestProject but I've already fixed them |
| 14:21.32 | atermenji | 1 failure left in TestProject. It is at.tugraz.ist.catroid.test.ui.MainMenuActivityTest.testShouldNotCrashIfProjectIsNull |
| 14:22.00 | atermenji | there is no way to fix it afaik because ABS is not working correctly with ActivityUnitTestCase |
| 14:22.32 | atermenji | so I'm waiting in the build queue on Jenkins to run my branch several times more |
| 14:24.15 | atermenji | 1 problem still left. ABS throws ArrayIndexOutOfBounds exception in random cases and this fails Jenkins build. It appears on random tests. It was not throwed in my last build so all the tests passed |
| 14:24.35 | ptreitler | very nice, good job! |
| 14:24.39 | atermenji | I am investigating this issue and I've wrote an issue on ABS repo on github |
| 14:25.46 | ptreitler | ok |
| 14:26.31 | ptreitler | have you heard any updates from aried3r regarding the review / acceptance of your code? |
| 14:26.46 | ptreitler | haven't managed to get in touch with him since I got back from vacation... |
| 14:27.57 | atermenji | he looked through my last commits |
| 14:29.04 | atermenji | also we've discussed my build with contextual actionbar. have you looked at it? |
| 14:33.06 | ptreitler | yes |
| 14:33.25 | ptreitler | is that build still on a separate branch? |
| 14:34.32 | atermenji | yes it is |
| 14:34.49 | ptreitler | actionbar_features, right? |
| 14:34.55 | atermenji | I want to merge it when my main branch "adding_fragments " will be accepted |
| 14:35.06 | atermenji | exactly |
| 14:36.50 | ptreitler | ok, will check it out |
| 14:37.00 | ptreitler | what's your plan for when you're finished with the UI tests? |
| 14:37.19 | ptreitler | afk for a couple of minutes |
| 14:37.50 | atermenji | I want my branch adding_fragments to be merged asap :) |
| 14:38.30 | atermenji | I've changed a lot of files there and had a lot of merging conflicts when pulling from master couple of times |
| 14:39.14 | atermenji | also we planned to add ABS lib as a git submodule to the repo with Anton |
| 14:39.53 | atermenji | when my branch will be merged I want to do merge with actionbar_features branch |
| 14:40.16 | atermenji | and after that I plan to implement tablet multipane layouts |
| 17:01.50 | ptreitler | yes, we'd like to have it merged asap too :) |
| 17:28.53 | *** join/#catroid atermenji1 (~atermenji@satellite4.donapex.net) |
| 20:53.01 | aried3r | atermenji1: Finally got a connection where SSH port is open. |
| 20:53.31 | atermenji1 | traveling? |
| 20:53.58 | aried3r | Regarding the final evaluation, there's no problem from my point of view if things continue like they are now. |
| 20:54.11 | aried3r | Somewhat. Work forces me to travel. |
| 20:54.58 | aried3r | Freelancing with a bit of web stuff. |
| 20:55.11 | atermenji1 | Python ? |
| 20:55.27 | aried3r | Sadly not. Existing framework. php :\ |
| 20:55.57 | aried3r | Anyway, we're having a release meeting on Monday as you probably know. |
| 20:56.22 | aried3r | I'll try to convince everyone that your branch should be merged before the release. |
| 20:56.47 | aried3r | Shouldn't take much effort, since your ticket on our local Kanban Wall has a 'red dot'. Meaning, there'll be no release without that. |
| 20:57.28 | aried3r | If we're lucky, we can merge before others. >:D |
| 21:00.48 | aried3r | Just looked at the test results. #36 looks promising. |
| 21:04.44 | atermenji1 | 5 min afk |
| 21:05.06 | *** join/#catroid ptreitler_ (~ptreitler@178-191-207-173.adsl.highway.telekom.at) |
| 21:06.48 | atermenji1 | yeah all test from UI test project are passing as I already said to Peter |
| 21:07.29 | atermenji1 | there is 1 test failure in TestProject. It appears because ABS is not working correctly with AndroidUnitTestCase |
| 21:07.39 | aried3r | Just read the backlog. |
| 21:07.51 | aried3r | Ok, the one with 'use Theme.Sherlock.Liight'? |
| 21:07.58 | atermenji1 | I can leave it as it is, delete the test or reimplement it in some other way |
| 21:08.03 | atermenji1 | yes, exactly |
| 21:12.46 | *** join/#catroid atermenji (~atermenji@satellite3.donapex.net) |
| 21:18.09 | atermenji | back |
| 21:19.22 | atermenji | so there is only one problem left. that random ArrayIndexOutOfBounds exceptions in ABS |
| 21:21.02 | atermenji | I've wrote an issue on ABS repo. but no response currently. |
| 21:21.19 | atermenji | I am trying to test with the latest robotium right now (3.3.1) |
| 21:21.56 | atermenji | if it fails I'll try to surround with try catch statement lines in ABS which are causing the exception |
| 21:24.14 | atermenji | anyway tests are passing, my branch is stable and I think it can be merged once I'll find a workaround for that ABS issue |
| 21:25.25 | atermenji | what do you think about all this ? :) |
| 21:35.24 | atermenji | aried3r here? |
| 21:40.09 | aried3r | What are the fixes in 3.3.1? |
| 21:40.50 | aried3r | I also think so. But the code review will take some time. I have to get it accepted by kaufmaster probably. Least thing we should do to distribute the knowledge of the changes. |
| 21:41.11 | aried3r | But I'll review all of it (just compare master and your branch) and ask you if I have problems understanding some changes. |
| 21:41.47 | aried3r | I'll also look at the test coverage to see if it decreased and if so, why. |
| 21:42.05 | aried3r | But I'm fairly positive that we can merge very soon. |
| 21:42.32 | atermenji | test coverage decreased because of ABS. we need to exclude it from emma |
| 21:42.52 | aried3r | True |
| 21:42.52 | atermenji | https://github.com/jayway/robotium/commits/master |
| 21:43.10 | atermenji | author of Robotium pushed several commits from 3.3 release |
| 21:43.26 | aried3r | Oh, cool. waitForFragment |
| 21:43.37 | atermenji | also I've made a pull request to Robotium today https://github.com/jayway/robotium/pull/26 |
| 21:44.17 | aried3r | Very nice |
| 21:47.38 | atermenji | when do you plan to release on Google Play? August 13? |
| 21:52.34 | atermenji | also I will be offline tomorrow. I'll schedulte 3-5 builds on Jenkins today before going to sleep. Nobody is building at night anyway |
| 21:58.47 | atermenji | new robotium build failed :( |
| 22:00.28 | atermenji | aried3r I hope to resolve the issue with random exceptions on weekend. Since this is the only issue left before merging you can start reviewing the code with the team, so that we could merge sooner. hope to do it before others :) send me a mail if you'll have any questions |
| 22:10.58 | aried3r | Will do. |
| 22:11.01 | aried3r | Thanks |
| 22:13.47 | atermenji | if you plan to release on 13th probably I can also merge with contextual abs branch and spend some time implementing multi pane layouts |
| 22:30.39 | *** part/#catroid ptreitler_ (~ptreitler@178-191-207-173.adsl.highway.telekom.at) |
| 22:43.47 | aried3r | But please remember that we cannot merge new features without tests. |
| 22:45.29 | atermenji | I've spent to much time on fixing tests, so I always have this in mind :) |
| 22:45.37 | aried3r | Good :) |
| 22:48.16 | *** part/#catroid atermenji (~atermenji@satellite3.donapex.net) |