| 00:21.22 | CIA-57 | BRL-CAD: 03starseeker * r48369 10/brlcad/trunk/src/conv/proe-g.c: Check for wmem before we start playing with matricies - if we don't have it, warn and ignore. CID 256 |
| 06:10.47 | brlcad | looks like gcc10 is down tonight |
| 06:11.05 | brlcad | had to re-setup the entire build env on a diff host |
| 06:11.13 | brlcad | ugh |
| 06:11.31 | brlcad | run5 being scanned now |
| 07:43.38 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 09:00.10 | *** join/#brlcad cadman (~Adium@64.178.177.71) |
| 09:16.51 | *** join/#brlcad jordisayol (~jordisayo@unaffiliated/jordisayol) |
| 09:48.35 | CIA-57 | BRL-CAD: 03indianlarry * r48370 10/brlcad/trunk/src/libged/ (make_pnts.c wdb_obj.c): Additional cleanup of cases where assignment made in 'if' conditional but variable never used. Relates to Coverity Run 5 CID 1704, 1705 |
| 09:51.24 | CIA-57 | BRL-CAD: 03indianlarry * r48371 10/brlcad/trunk/src/conv/step/ (EdgeCurve.cpp EdgeCurve.h Ellipse.cpp): Added initialization for all class fields in constructor. Relates to Run 5 CID 1975,1976,1979,1980. |
| 10:24.04 | CIA-57 | BRL-CAD: 03indianlarry * r48372 10/brlcad/trunk/src/conv/step/ (11 files): Added initialization for all class fields in constructor to take care of coverity UNINIT_CTOR. Relates to Run 5 CID 1934, 1977, 1984-97 |
| 10:39.05 | CIA-57 | BRL-CAD: 03indianlarry * r48373 10/brlcad/trunk/src/conv/step/ (5 files): Added initialization for all class fields in constructor to take care of coverity UNINIT_CTOR. Relates to Run 5 CID 1937,1955,1956,1978 |
| 10:55.18 | CIA-57 | BRL-CAD: 03indianlarry * r48374 10/brlcad/trunk/src/conv/step/ (7 files): Added initialization for all class fields in constructor to take care of coverity UNINIT_CTOR. Relates to Run 5 CID 1999,2000,2002-7,2009-10,2012-13 |
| 11:09.59 | CIA-57 | BRL-CAD: 03indianlarry * r48375 10/brlcad/trunk/src/conv/step/ (9 files): Added initialization for all class fields in constructor to take care of coverity UNINIT_CTOR. Relates to Run 5 CID 2008, 2011, 2019-20, 2022-33 |
| 12:04.34 | CIA-57 | BRL-CAD: 03indianlarry * r48376 10/brlcad/trunk/src/conv/step/Factory.cpp: Added check for NULL before calling method pointer resolving FORWARD_NULL issue from coverity. Relates to CIDs: 1840-43 |
| 12:36.43 | *** join/#brlcad Stattrav (~Stattrav@61.12.114.82) |
| 12:36.43 | *** join/#brlcad Stattrav (~Stattrav@unaffiliated/stattrav) |
| 13:53.44 | CIA-57 | BRL-CAD: 03starseeker * r48377 10/brlcad/trunk/src/librt/primitives/nmg/nmg_rt_isect.c: By this point in the code logic, myhit is actually completely moot - shouldn't be trying to log it at all. CID 245, 2055 |
| 14:01.11 | CIA-57 | BRL-CAD: 03starseeker * r48378 10/brlcad/trunk/src/conv/comgeom/cvt.c: We actually want to return if argv is NULL, not if it's true. CID 1771, 2057 |
| 14:05.44 | CIA-57 | BRL-CAD: 03starseeker * r48379 10/brlcad/trunk/src/libged/comb.c: Don't appear to need this lookup in the first place. CID 1702, 2056 |
| 14:09.56 | CIA-57 | BRL-CAD: 03starseeker * r48380 10/brlcad/trunk/src/conv/obj-g.c: Only try the nmg_km if we have fu - move the call inside the protection of the null check. CID 2058 |
| 14:23.46 | CIA-57 | BRL-CAD: 03starseeker * r48381 10/brlcad/trunk/src/fb/gif2fb.c: magic is bigger than Header.GH_Magic - we only want to memcpy the length of Header.GH_Magic. CID 2059 |
| 14:23.48 | *** join/#brlcad packrat (~packrator@c-98-209-146-133.hsd1.mi.comcast.net) |
| 14:29.20 | CIA-57 | BRL-CAD: 03starseeker * r48382 10/brlcad/trunk/src/libged/red.c: Ah, right, goto means we could be skipping fclose. Don't want to do that. CID 2060 |
| 14:33.59 | CIA-57 | BRL-CAD: 03starseeker * r48383 10/brlcad/trunk/src/fb/pl-fb.c: Stray return left over from CID 127 cleanup. CID 2061 |
| 14:49.54 | CIA-57 | BRL-CAD: 03starseeker * r48384 10/brlcad/trunk/src/libged/bot_dump.c: Go ahead and check the fp before calling the write functions for bot_dump... CID 243 |
| 15:09.43 | CIA-57 | BRL-CAD: 03brlcad * r48385 10/brlcad/trunk/src/libbu/parallel.c: don't set ncpu to 1 if the method of detecting cpus fails. there may be alternate/additional methods available that can succeed. this prevents a DEADCODE condition reported by coerity (cov cid 160) |
| 15:13.19 | CIA-57 | BRL-CAD: 03brlcad * r48386 10/brlcad/trunk/src/conv/g-nff.c: ws, style |
| 15:14.04 | CIA-57 | BRL-CAD: 03brlcad * r48387 10/brlcad/trunk/src/conv/g-nff.c: wow, k&r main() but not the rest. |
| 15:30.36 | CIA-57 | BRL-CAD: 03r_weiss * r48388 10/brlcad/trunk/src/conv/iges/ (check_names.c g-iges.c): Cleanup of iges-g and g-iges converters. Removed a possible race condition by using the 'access' function instead of 'stat'. Cleanup of logic for creating unique brlcad names. |
| 15:37.26 | CIA-57 | BRL-CAD: 03n_reed * r48389 10/brlcad/trunk/src/librt/primitives/nmg/nmg_rt_isect.c: remove duplicated if test, CID 2055 |
| 15:46.12 | CIA-57 | BRL-CAD: 03indianlarry * r48390 10/brlcad/trunk/src/conv/step/ (EdgeCurve.cpp OrientedEdge.cpp): Added check for NULL before using entiry field to resolve FORWARD_NULL issue from coverity. Relates to CIDs: 1844-5 |
| 16:04.23 | CIA-57 | BRL-CAD: 03starseeker * r48391 10/brlcad/trunk/src/libpkg/pkg.c: service shouldn't be null with pkg_permserver - just check for it up front. CID 257 |
| 16:08.33 | CIA-57 | BRL-CAD: 03indianlarry * r48392 10/brlcad/trunk/src/conv/step/PullbackCurve.cpp: Preprocessed out "dead_code", eventually remove but offers alternative to curve fitting method used for pullback. Should quell coverity scan CID 1838 |
| 16:08.46 | CIA-57 | BRL-CAD: 03r_weiss * r48393 10/brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c: Updated file 'nmg_mk.c' function 'nmg_demote_lu'. Fixed error when debug enabled when an element is referenced after freed. |
| 16:12.43 | CIA-57 | BRL-CAD: 03starseeker * r48394 10/brlcad/trunk/src/libpkg/pkg.c: Check for null pc->pkc_buf - CID 258 |
| 16:27.46 | CIA-57 | BRL-CAD: 03starseeker * r48395 10/brlcad/trunk/src/irprep/ir-X.c: Don't fool around with this - if scanf fails and we have no file pointer, exit. CID 259 |
| 16:41.25 | CIA-57 | BRL-CAD: 03starseeker * r48396 10/brlcad/trunk/src/lgt/do_options.c: Check for NULL args case, log and return appropriately. CID 260 |
| 16:43.11 | CIA-57 | BRL-CAD: 03n_reed * r48397 10/brlcad/trunk/src/conv/step/PCurveOrSurface.cpp: removed extra semicolons |
| 16:44.01 | CIA-57 | BRL-CAD: 03r_weiss * r48398 10/brlcad/trunk/src/librt/primitives/nmg/nmg_extrude.c: Updated file 'nmg_extrude.c' function 'nmg_break_crossed_loops'. Removed potential use of 'pt' before it is initialized. Presently 'nmg_break_crossed_loops' is not being called. |
| 16:51.44 | CIA-57 | BRL-CAD: 03r_weiss * r48399 10/brlcad/trunk/src/librt/primitives/nmg/nmg_mk.c: Updated file 'nmg_mk.c' function 'nmg_demote_eu'. Removed potential of referencing an element after it is freed. |
| 16:55.00 | CIA-57 | BRL-CAD: 03starseeker * r48400 10/brlcad/trunk/src/lgt/do_options.c: Check for NULL args case, log and return appropriately. CID 261 |
| 16:58.10 | CIA-57 | BRL-CAD: 03starseeker * r48401 10/brlcad/trunk/src/lgt/do_options.c: Check for NULL args case, log and return appropriately. CID 262 |
| 16:58.27 | CIA-57 | BRL-CAD: 03r_weiss * r48402 10/brlcad/trunk/src/librt/primitives/nmg/nmg_bool.c: Updated file 'nmg_bool.c' function 'nmg_booltree_leaf_tess'. Removed potential of referencing an uninitialized pointer. |
| 17:05.28 | CIA-57 | BRL-CAD: 03r_weiss * r48403 10/brlcad/trunk/src/librt/primitives/nmg/nmg_tri.c: Updated funtion 'nmg_plot_fu' in file 'nmg_tri.c'. Removed an unused variable which was giving a coverity error of uninitialized. |
| 17:12.14 | CIA-57 | BRL-CAD: 03starseeker * r48404 10/brlcad/trunk/src/lgt/do_options.c: Check for null svkey_fp - CID 263 |
| 17:20.07 | CIA-57 | BRL-CAD: 03starseeker * r48405 10/brlcad/trunk/src/lgt/reflect.c: Check for NULL lgt_entry. CID 264 |
| 17:29.38 | CIA-57 | BRL-CAD: 03starseeker * r48406 10/brlcad/trunk/src/libdm/dm-X.c: Make sure we have pt_prev before proceeding to use it - CID 265 |
| 17:33.13 | CIA-57 | BRL-CAD: 03starseeker * r48407 10/brlcad/trunk/src/libdm/dm-plot.c: Make sure we have pt_prev before proceeding to use it - CID 266 |
| 17:38.45 | CIA-57 | BRL-CAD: 03starseeker * r48408 10/brlcad/trunk/src/libdm/dm-tk.c: Make sure we have pt_prev before proceeding to use it - CID 267 |
| 17:41.18 | CIA-57 | BRL-CAD: 03brlcad * r48409 10/brlcad/trunk/src/libbu/convert.c: convert from manually trying to test the platform endian to using bu_byteorder(). this should take care of a coverity DEADCODE issue since it's not based on sizeof(). (cov cid 161) |
| 17:41.36 | CIA-57 | BRL-CAD: 03starseeker * r48410 10/brlcad/trunk/src/libfb/fb_obj.c: If we get FBIO_NULL, return an error. CID 269 |
| 17:44.51 | CIA-57 | BRL-CAD: 03indianlarry * r48411 10/brlcad/trunk/src/conv/step/ (7 files): Added checks on known NULL returning functions to quell NULL_RETURNS issues from coverity. Relates to coverity CIDs Run 5 :1853-9 |
| 17:47.06 | CIA-57 | BRL-CAD: 03starseeker * r48412 10/brlcad/trunk/src/libfb/if_X.c: If we're going to check for ifp, don't do anything that might require ifp without the OK. Not entirely clear if there should be some failure case here, of the 'sliently ignore' behavior is preferred... CID 270 |
| 17:48.15 | CIA-57 | BRL-CAD: 03brlcad * r48413 10/brlcad/trunk/src/libbu/convert.c: eh, reduce. Endian isn't used other than to check if we're big endian so just eliminate the static altogether (which was a multithreading issue anyways). (cov cid 161) |
| 17:53.25 | CIA-57 | BRL-CAD: 03starseeker * r48414 10/brlcad/trunk/src/libfb/if_X.c: is_linear means we don't have a cmp - in that case, don't try to use it. CID 271 |
| 17:56.23 | CIA-57 | BRL-CAD: 03n_reed * r48415 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: forgot to dereference counter pointer before increment, CID 97 |
| 18:00.43 | CIA-57 | BRL-CAD: 03starseeker * r48416 10/brlcad/trunk/src/libfb/if_mem.c: Check if file is NULL up front. CID 272 |
| 18:03.47 | CIA-57 | BRL-CAD: 03r_weiss * r48417 10/brlcad/trunk/src/conv/obj-g.c: Updated file 'obj-g.c' function 'main'. Coverity CID 1777. Changed the file name string to use vls strings instead of pointing back to the input arg list string. |
| 18:09.19 | CIA-57 | BRL-CAD: 03starseeker * r48418 10/brlcad/trunk/src/libpkg/pkg.c: Don't do the PKC_ERROR cast - not correct. |
| 18:21.23 | CIA-57 | BRL-CAD: 03brlcad * r48419 10/brlcad/trunk/src/libbu/convert.c: eliminate a DEADCODE condition reported by coverity since the logic will never be CV_D at this point in the code. (cov cid 162) |
| 18:32.22 | CIA-57 | BRL-CAD: 03starseeker * r48420 10/brlcad/trunk/src/libged/bigE.c: Make sure we have eptr before trying to use it in the LEAF case. CID 273 |
| 18:37.12 | CIA-57 | BRL-CAD: 03starseeker * r48421 10/brlcad/trunk/src/libged/draw.c: Add a check for tsp not being NULL - CID 274 |
| 18:45.55 | CIA-57 | BRL-CAD: 03starseeker * r48422 10/brlcad/trunk/src/libged/bot_dump.c: Do some sanity checking on fp in data_dump. CID 275 |
| 18:50.21 | CIA-57 | BRL-CAD: 03starseeker * r48423 10/brlcad/trunk/src/libged/bot_split.c: Put the rt_db_put_internal call using dp inside the check for the NULL condition - safer. CID 276 |
| 18:52.55 | CIA-57 | BRL-CAD: 03brlcad * r48424 10/brlcad/trunk/src/libbu/parse.c: missing break statement on unimplemented switch case. fixes coverity MISSING_BREAK defect (cov cid 345). |
| 19:04.46 | CIA-57 | BRL-CAD: 03starseeker * r48425 10/brlcad/trunk/src/librt/primitives/brep/brep_debug.cpp: Wrap the brep uses inside the null checks. CID 277-291 |
| 19:20.01 | CIA-57 | BRL-CAD: 03indianlarry * r48426 10/brlcad/trunk/src/conv/step/PullbackCurve.cpp: Removed unused debug code causing coverity CID 2037. |
| 19:22.09 | CIA-57 | BRL-CAD: 03starseeker * r48427 10/brlcad/trunk/misc/CMake/PERPLEX_Util.cmake: If the perplex template changes, we want to do a rebuild of the tools that use it. |
| 19:28.10 | CIA-57 | BRL-CAD: 03starseeker * r48428 10/brlcad/trunk/src/other/perplex/scanner_template.c: Make sure we have buf before we void out buf->elts. Scanner template fix will impact all users of perplex - CID 1839 |
| 19:33.33 | CIA-57 | BRL-CAD: 03bob1961 * r48429 10/brlcad/trunk/src/libged/ (glob.c qray.c): To appease MGED when it doesn't have a database open, GED_OK needs to be returned when the qray or glob commands are called. |
| 19:41.42 | *** join/#brlcad cadman (~Adium@mwg-e04.infosec.fedex.com) |
| 19:55.46 | CIA-57 | BRL-CAD: 03bob1961 * r48430 10/brlcad/trunk/src/librt/primitives/nmg/nmg_eval.c: run 5, CID 2041. Removed the offending debug statement. |
| 20:00.53 | CIA-57 | BRL-CAD: 03r_weiss * r48431 10/brlcad/trunk/src/conv/obj-g.c: Updated file 'obj-g.c' file to correct type errors. Coverity CID 1765. |
| 20:13.55 | CIA-57 | BRL-CAD: 03indianlarry * r48432 10/brlcad/trunk/src/conv/step/PullbackCurve.cpp: |
| 20:13.57 | CIA-57 | BRL-CAD: Now getting last element in Std::List by using "data.segments.back()" (after |
| 20:13.59 | CIA-57 | BRL-CAD: check to make sure list is not empty) instead of misusing iterator |
| 20:13.59 | CIA-57 | BRL-CAD: "data.segments.end()" walking past the end of its container. Relates to Run 5 |
| 20:13.59 | CIA-57 | BRL-CAD: CID 1851. |
| 20:30.05 | CIA-57 | BRL-CAD: 03r_weiss * r48433 10/brlcad/trunk/src/conv/obj-g.c: Updated file 'obj-g.c' to correct a bug where a null pointer could be dereferenced. Coverity CID 1739. |
| 20:33.01 | CIA-57 | BRL-CAD: 03starseeker * r48434 10/brlcad/trunk/src/libdm/dm-ps.c: Make sure pt_prev isn't NULL before trying to use it - CID 267 |
| 20:35.15 | CIA-57 | BRL-CAD: 03bob1961 * r48435 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: run 5, CID 1929. Initialize a variable before it gets used (for covarity). |
| 20:35.20 | CIA-57 | BRL-CAD: 03starseeker * r48436 10/brlcad/trunk/src/libged/wdb_bigE.c: Check eptr before we use it. CID 292 |
| 20:54.09 | CIA-57 | BRL-CAD: 03indianlarry * r48437 10/brlcad/trunk/src/conv/step/ (33 files): Reset stream "sticky" setting of std::Hex back to std::dec. Related to CIDs: 1884-1924. |
| 20:54.26 | CIA-57 | BRL-CAD: 03starseeker * r48438 10/brlcad/trunk/src/libged/dg_obj.c: Don't do the tsp assignment unless we actually have tsp - CID 293 |
| 20:57.47 | CIA-57 | BRL-CAD: 03starseeker * r48439 10/brlcad/trunk/src/libged/ls.c: Make sure we have type before we call strlen - CID 294 |
| 21:08.45 | CIA-57 | BRL-CAD: 03starseeker * r48440 10/brlcad/trunk/src/librt/primitives/nmg/nmg_misc.c: Check fu_base before using it - Coverity thinks there's a path to get there that can have fu_base NULL. CID 295 |
| 21:10.36 | CIA-57 | BRL-CAD: 03indianlarry * r48441 10/brlcad/trunk/src/conv/step/NamedUnit.cpp: Added coverity suggested work-around for double-free of virtual base class memory in destructor by setting freed member to NULL. Relates to CIDs: 2042-53 |
| 21:10.38 | CIA-57 | BRL-CAD: 03n_reed * r48442 10/brlcad/trunk/src/libcursor/cursor.c: terminate potentially unterminated string, CID 108 |
| 21:11.09 | CIA-57 | BRL-CAD: 03starseeker * r48443 10/brlcad/trunk/src/libged/wdb_obj.c: Make sure type isn't null before calling strlen - CID 299 |
| 21:11.12 | *** join/#brlcad DarkCalf (DC@173.231.40.98) |
| 21:23.45 | CIA-57 | BRL-CAD: 03n_reed * r48444 10/brlcad/trunk/src/libpkg/pkg.c: terminate possibly unterminated strings, CID 109, CID 110 |
| 22:05.49 | CIA-57 | BRL-CAD: 03n_reed * r48445 10/brlcad/trunk/src/liborle/rle.c: always check returns from getc, CID 112, 115, 116 |
| 22:08.12 | CIA-57 | BRL-CAD: 03bob1961 * r48446 10/brlcad/trunk/src/libged/glob.c: Need to check gedp for NULL up front. If a database has not been opened return without complaint. Note - the command and it's args are in ged_result_str. |
| 22:19.14 | CIA-57 | BRL-CAD: 03bob1961 * r48447 10/brlcad/trunk/ (include/bu.h src/libbu/CMakeLists.txt src/libbu/ctype.c): Added bu_str_isprint. |
| 22:39.47 | CIA-57 | BRL-CAD: 03bob1961 * r48448 10/brlcad/trunk/src/conv/intaval/tgf-g.cpp: run 5, CID 1927, tainted string. Atleast check to make sure the string is not NULL and consists of printable characters. |
| 22:40.40 | CIA-57 | BRL-CAD: 03bob1961 * r48449 10/brlcad/trunk/src/libbu/ctype.c: Tweak bu_str_isprint to return 0 for empty strings. |
| 23:11.22 | CIA-57 | BRL-CAD: 03starseeker * r48450 10/brlcad/trunk/src/librt/prep.c: Make sure of tsp before we do something with it. CID 300 |
| 23:16.43 | CIA-57 | BRL-CAD: 03starseeker * r48451 10/brlcad/trunk/src/libbu/parse.c: Check parsetab before using it - CID 301 |
| 23:36.08 | CIA-57 | BRL-CAD: 03brlcad * r48452 10/brlcad/trunk/src/nirt/nirt.h: make nirt prompt only have one space after the prompt |
| 23:50.39 | *** join/#brlcad juanman (~quassel@unaffiliated/juanman) |
| 23:51.44 | CIA-57 | BRL-CAD: 03brlcad * r48453 10/brlcad/trunk/ (9 files in 6 dirs): |
| 23:51.44 | CIA-57 | BRL-CAD: refactor bu_list_path() and bu_count_path() into a new bu_dir_list() function |
| 23:51.44 | CIA-57 | BRL-CAD: that performs both. returns the count now and optionally takes a pattern |
| 23:51.44 | CIA-57 | BRL-CAD: (instead of a suffix) and conditionally handles all of the memory allocation for |
| 23:51.45 | CIA-57 | BRL-CAD: the caller automatically. fixed a memory leak and off-by-one bug. documented |
| 23:51.45 | CIA-57 | BRL-CAD: the new function and one caller in nirt accordingly. initiated in response to |
| 23:51.46 | CIA-57 | BRL-CAD: RESOURCE_LEAK reported by coverity (cov cid 478). |
| 23:59.06 | CIA-57 | BRL-CAD: 03starseeker * r48454 10/brlcad/trunk/src/librt/primitives/revolve/revolve_brep.cpp: Reworking of polycurve handling in revolve_brep.cpp - CID 306 |