| 00:20.48 | *** join/#asterisk-dev infobot (ibot@rikers.org) |
| 00:20.48 | *** topic/#asterisk-dev is Asterisk Development Discussion -=- http://www.asterisk.org/developers -=- Tier 2 and 3.14159265 support is in #asterisk -=- Check out our blog! blogs.asterisk.org -=- Follow on Twitter at @AsteriskDev |
| 00:53.51 | coreyfarrell | gtjoseph: sorry been real busy lately. I hadn't looked at the statsd part of it, I had only commented about the self_test failure which kharwell addressed. |
| 02:13.26 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:ffae:7c6a:c76a:dfb6:ff02) |
| 02:13.26 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 02:22.45 | *** join/#asterisk-dev gtjoseph (~gtjoseph@unaffiliated/gtj) |
| 02:22.45 | *** mode/#asterisk-dev [+o gtjoseph] by ChanServ |
| 04:31.23 | *** join/#asterisk-dev coreyfarrell (~coreyfarr@24-177-250-191.dhcp.nwtn.ct.charter.com) |
| 04:31.23 | *** mode/#asterisk-dev [+o coreyfarrell] by ChanServ |
| 06:08.06 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:08.06 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:57.16 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:5deb:74a0:be73:2d74) |
| 08:11.40 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 09:51.52 | *** join/#asterisk-dev jkroon (~jkroon@165.16.203.57) |
| 12:24.55 | gtjoseph | coreyfarrell: got a sec for a module reference question? |
| 12:25.38 | gtjoseph | if module A calls a function in module B and that function does an ast_module_unref(ast_module_info->self), whic module gets unreffed? |
| 12:28.51 | coreyfarrell | ast_module_info is a private/static symbol per module so it always refers to the module which directly calls it. |
| 12:29.09 | gtjoseph | heh |
| 12:29.20 | gtjoseph | so there's an issue in pjsip_session.c |
| 12:29.54 | gtjoseph | if a module calls ast_sip_session_unregister_supplement and it fails, res_pjsip will be unreffed. |
| 12:30.31 | coreyfarrell | which branch? |
| 12:31.32 | gtjoseph | 13 |
| 12:33.26 | coreyfarrell | I'm confused. if internal_sip_session_unregister_supplement finds the module it sets res = 0, then ast_sip_session_unregister_supplement calls the unref (on success). |
| 12:34.05 | gtjoseph | ah yes, i had the logic reversed. still it unreffs res_pjsip not the callingmodule. |
| 12:35.51 | coreyfarrell | that's correct. when a module registers a session supplement it holds a reference against res_pjsip. the only time a module would call ast_sip_session_unregister_supplement is during it's unload which wouldn't be possible it we were holding a reference to it. |
| 12:36.44 | gtjoseph | ah ok |
| 12:37.40 | coreyfarrell | likely doesn't matter for res_pjsip but that ref / unref forces unload order, res_pjsip can never unload before any module with a call to ast_sip_session_register_supplement. |
| 13:53.17 | *** join/#asterisk-dev sahmed (3f417816@gateway/web/freenode/ip.63.65.120.22) |
| 13:53.55 | *** part/#asterisk-dev sahmed (3f417816@gateway/web/freenode/ip.63.65.120.22) |
| 14:17.01 | *** join/#asterisk-dev bford (uid283514@gateway/web/irccloud.com/x-gkxqxgwibrdfxemd) |
| 14:17.01 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:27.39 | gtjoseph | coreyfarrell: you removed the return code from ast_sip_session_register_supplement in master. do you remember why? The commit messages don't say. |
| 14:28.05 | gtjoseph | commit 527cf5a5703 and 527cf5a5703 |
| 14:28.12 | gtjoseph | oops 7d045449869 |
| 14:34.47 | *** join/#asterisk-dev cresl1n (uid299068@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 14:34.47 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 16:08.39 | *** join/#asterisk-dev dakudos (~dakudos@c-73-243-106-97.hsd1.co.comcast.net) |
| 16:44.14 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d008cb702ce8529c21e.ipv6.abo.wanadoo.fr) |
| 17:39.45 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.164) |
| 19:08.25 | *** join/#asterisk-dev kados__ (~dakudos@c-73-243-106-97.hsd1.co.comcast.net) |
| 19:11.58 | coreyfarrell | gtjoseph: I think I removed it because it was pointless (it always returned 0 but callers still checked the result and had error handling). |
| 19:12.12 | gtjoseph | kk, thanks |
| 19:24.50 | *** join/#asterisk-dev sahmed (3f417816@gateway/web/freenode/ip.63.65.120.22) |
| 19:24.58 | sahmed | Hello |
| 19:25.34 | sahmed | I am facing some issue on * testsuite build |
| 19:26.00 | sahmed | could anybody please help me on that? |
| 19:26.11 | gtjoseph | what kind of problem are you having? |
| 19:26.32 | sahmed | I have followed all instruction on https://wiki.asterisk.org/wiki/display/AST/Installing+the+Asterisk+Test+Suite |
| 19:27.12 | sahmed | after running the runtest.py with "tests/channels/pjsip" it gives an error like "[Jun 07 19:02:52] ERROR[8033]: twisted:455 emit: Unhandled Error" |
| 19:27.38 | gtjoseph | which distribution and version are you running? |
| 19:28.41 | sahmed | asterisk version: 13.20 testsuite: Download from git |
| 19:28.51 | gtjoseph | there's also a new contrib/scripts/install_prereq script in the testsuite directory that you can run. |
| 19:29.03 | gtjoseph | Sorry, I meant CentOS, Ubuntu, Fedora, etc. |
| 19:29.22 | sahmed | its debian(Jassie) |
| 19:30.06 | gtjoseph | how did you install the python libraries? from the distro or pip, etc? |
| 19:30.22 | gtjoseph | i'd suggest running the install_prereq script and testing again. |
| 19:30.42 | sahmed | ok let me run this |
| 19:30.52 | sahmed | thanks for your response |
| 19:30.59 | gtjoseph | no problem |
| 19:36.08 | sahmed | No, I got this again, [Jun 07 19:34:51] ERROR[11510]: twisted:455 emit: Unhandled Error |
| 19:36.20 | sahmed | twisted:455 emit: Unhandled error in Deferred: |
| 19:36.33 | sahmed | Unhandled error in Deferred: |
| 19:36.34 | gtjoseph | <PROTECTED> |
| 19:36.59 | sahmed | using apt-get |
| 19:37.50 | sahmed | python/oldstable,now 2.7.9-1 amd64 |
| 19:38.03 | gtjoseph | it's possible that the versions of twisted, autobahn, etc in the distro are too old |
| 19:38.45 | sahmed | ok |
| 19:38.47 | gtjoseph | i'm not that familiar with debian and we don't test on it at all |
| 19:39.38 | sahmed | can I reload all new and try again? |
| 19:39.46 | sahmed | python* |
| 19:40.07 | gtjoseph | I'd remove the python-twisted and autobahn packages and install using pip. |
| 19:40.23 | sahmed | ok let me try this |
| 19:55.13 | *** join/#asterisk-dev naf419 (46b9d47d@gateway/web/freenode/ip.70.185.212.125) |
| 19:56.27 | naf419 | anybody already working on adding compatability with google voice's new SIP servers? |
| 19:57.53 | file | I know of noone working on such a thing. |
| 20:05.00 | sahmed | <@gtjoseph> is there any recommendation to use python3 for this? |
| 20:05.13 | naf419 | i started looking at modding pjsip for that purpose. problem #1 appears to be that all of pjsip's auth mechanisms rely on the SIP server requesting authorization, which GV aint gonna do |
| 20:27.47 | sahmed | <@gtjoseph> Installed python-twisted using pip but no luck :( |