| 00:02.54 | *** join/#asterisk-dev shymega (~shymega@torbaytechjam/shymega) |
| 00:36.31 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:843d:1bfe:7155:7b81) |
| 00:36.31 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 00:46.02 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:848c:2a89:8cfb:8536) |
| 00:46.02 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 00:48.25 | seanbright | gtjoseph: you around? |
| 00:48.54 | gtjoseph | yep |
| 00:49.08 | seanbright | https://github.com/asterisk/asterisk/blob/master/main/config.c#L994 |
| 00:49.17 | seanbright | is that pointer comparison intentional? |
| 00:49.32 | seanbright | i ask because you wrote this 2 years ago |
| 00:49.33 | seanbright | :-) |
| 00:50.16 | gtjoseph | two years, holy moly |
| 00:51.16 | gtjoseph | are you talking about the "cat->name == category_name" comparison? |
| 00:51.21 | seanbright | yes |
| 00:51.40 | seanbright | i haven't dug down enough in this code yet to completely understand what is going on and that jumped out at me |
| 00:51.41 | gtjoseph | yeah it is, but i don't recall why now. |
| 00:51.52 | seanbright | k |
| 00:51.55 | seanbright | thank you, sir |
| 00:52.17 | gtjoseph | that whole file is bizarre |
| 00:52.28 | seanbright | i concur |
| 00:52.37 | gtjoseph | it's been on my (s)hit list for years |
| 00:52.38 | rmudgett | IIRC that is a quick comparison |
| 00:52.53 | seanbright | why do both of those loops do basically the same thing? |
| 00:53.34 | gtjoseph | because it forst tries to find an exact match |
| 00:53.39 | gtjoseph | iirc |
| 00:53.51 | gtjoseph | oh, no |
| 00:53.53 | gtjoseph | wait |
| 00:54.20 | gtjoseph | yeah you have to look at what does_category_match does with the filter |
| 00:54.27 | seanbright | k |
| 00:55.09 | gtjoseph | but damn i forget exactly. you do have to do a loop with the quick comparison first, then only if that fails, just do it with the does_category_match. |
| 00:55.38 | seanbright | if i figure out wtf is happening i will add a comment |
| 00:55.39 | seanbright | :-) |
| 00:55.52 | gtjoseph | cool. just don't mention my name |
| 00:57.01 | rmudgett | I think it is a find-next then find first situation. The first time you look it has to fall back to the second loop. The second time you pass in what was found the first time to find the next in the list. |
| 00:57.46 | rmudgett | Though I'm only looking at that one function and relying on memory fragments for the rest. :) |
| 01:09.52 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:64d8:697e:f19a:b663) |
| 01:09.52 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 01:22.57 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 01:22.57 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 02:40.34 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:85fc:7613:e1cc:c888) |
| 02:40.34 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:07.32 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:f583:2e0b:ff92:d5ce) |
| 04:07.32 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 04:55.01 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 04:55.01 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 06:54.58 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:f172:dfb0:1f2e:dcdf) |
| 06:54.58 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 07:27.07 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d00e1c16af403799267.ipv6.abo.wanadoo.fr) |
| 07:48.07 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 07:48.07 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 07:54.13 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:06.03 | *** join/#asterisk-dev jkroon (~jkroon@uls-154-73-35-201.wall.uls.co.za) |
| 08:14.45 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01:e0a:d:1111:1dd7:b42:3b85:c2f5) |
| 08:58.24 | *** join/#asterisk-dev pchero (~pchero@109.70.54.56) |
| 10:36.01 | stefan27 | What's the latest news for g729 in asterisk (13, 14, 15)? |
| 10:36.22 | stefan27 | Anyone wrote a blog entry about g729? |
| 13:00.58 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 13:00.58 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 13:58.46 | *** join/#asterisk-dev kharwell (kharwell@nat/digium/x-azhsmfrcszgwbbwh) |
| 13:58.47 | *** mode/#asterisk-dev [+o kharwell] by ChanServ |
| 14:01.01 | *** join/#asterisk-dev snuff-work (~snuff-wor@210.9.148.102) |
| 14:01.01 | *** mode/#asterisk-dev [+o snuff-work] by ChanServ |
| 14:07.53 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 14:07.53 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:28.17 | Gugge | stefan27: should there be any news, as anything changed? :) |
| 14:53.18 | coreyfarrell | anyone have an idea what to do about tests/rest_api/asterisk/modules/get_modules? it's blocking the optional api shutdown reference. |
| 14:55.14 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 14:55.14 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:55.25 | file | breaking it for older revisions is not an option, so that leaves the other two |
| 14:55.55 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 14:55.55 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:56.47 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 14:56.47 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:57.34 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 14:57.34 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:58.14 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 14:58.14 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 14:58.57 | coreyfarrell | file: I'm thinking that "use_count" is really an implementation detail of the module system, my personal feeling is we shouldn't check any of them. does yaml match checking have a way to match any number? or regex like: "use_count": /^\d+$/ |
| 15:20.20 | seanbright | looks like 6967 broken the 13 build |
| 15:20.33 | seanbright | the inclusion of editline/readline.h specifically |
| 15:22.59 | seanbright | changing to quotes instead of <> is the fix |
| 15:23.53 | coreyfarrell | seanbright: no I see the actual problem. |
| 15:24.06 | coreyfarrell | main/Makefile has: cli.o: _ASTCFLAGS+=$(LIBEDIT_INCLUDE) |
| 15:24.35 | coreyfarrell | this is needed for loader.o now. I'll get a review posted in a minute. |
| 15:24.43 | seanbright | k |
| 15:25.16 | seanbright | oddly, asterisk.c uses #include "editline/histedit.h" |
| 15:25.25 | seanbright | so not sure |
| 15:25.43 | coreyfarrell | hmm actually since this didn't break on my machine could I convince you to try it out? in main/Makefile just change the cli.o to loader.o. |
| 15:27.42 | coreyfarrell | I don't think LIBEDIT_INCLUDE is needed for cli.o anymore but since it'll built with or without on my system I can't test it. |
| 15:33.07 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-wpaskjexkuhvovjr) |
| 15:33.07 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 15:33.09 | seanbright | yes, that fixes it |
| 15:37.04 | file | I was in a meeting, now I'm not |
| 15:40.45 | coreyfarrell | seanbright: up for review 6972 - 6974 |
| 15:41.34 | coreyfarrell | thanks for catching that.. my system editline headers must be in a default include search path. |
| 16:02.11 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip184-182-52-160.ph.ph.cox.net) |
| 16:02.49 | *** join/#asterisk-dev CELYA_ (~Thunderbi@2a01cb0583d31d0031a1117b2f42bb4b.ipv6.abo.wanadoo.fr) |
| 16:35.35 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.164) |
| 17:13.42 | seanbright | first time giving rmudgett a -1... not sure how i feel about it |
| 17:16.46 | rmudgett | seanbright: There actually isn't any benefit over a char[] the way the ast_str is used. It was growing the stack in a loop before though. |
| 17:17.07 | seanbright | yeah, i know |
| 17:17.27 | seanbright | it was an attempt at delayed initialization |
| 17:18.34 | seanbright | hmmm |
| 17:19.11 | seanbright | DEVICE_STATE_SCHEME_STASIS "%s", ++name |
| 17:19.18 | seanbright | because i like to micro-optimize |
| 17:19.26 | seanbright | and i cannot lie |
| 17:21.16 | file | you other coders can't deny? |
| 17:22.40 | seanbright | correct |
| 17:44.28 | rmudgett | seanbright: You made me optimize it even more. :) |
| 17:50.07 | seanbright | i approve |
| 17:50.21 | seanbright | other than my preprocessor suggestion not making the cut |
| 19:40.52 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:40.52 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 19:56.23 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:56.23 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 20:32.36 | coreyfarrell | does "RFC:" commit line prevent jenkins from checking? |
| 20:32.58 | file | no |
| 20:34.29 | seanbright | https://gerrit.asterisk.org/#/c/6988/ |
| 20:34.33 | seanbright | take THAT mother fuckers |
| 20:57.41 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 20:57.41 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:03.11 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 21:03.12 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:04.00 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 21:04.00 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:04.54 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 21:04.54 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:05.39 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 21:05.39 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:06.28 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:a194:738d:7851:4429) |
| 21:06.28 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:09.43 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 21:09.43 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 21:27.42 | *** join/#asterisk-dev Dovid (~dovid@ool-45738ae3.dyn.optonline.net) |
| 21:37.33 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:d9b0:e01a:603f:f339) |
| 21:37.33 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 21:43.22 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 21:43.22 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 22:02.43 | *** part/#asterisk-dev kharwell (kharwell@nat/digium/x-azhsmfrcszgwbbwh) |
| 22:30.31 | *** join/#asterisk-dev DivideBy0 (~DivideBy0@unaffiliated/divideby0x0) |
| 22:30.31 | *** mode/#asterisk-dev [+o DivideBy0] by ChanServ |
| 23:24.06 | *** join/#asterisk-dev leedm777 (~textual@2604:2d80:8404:e2c6:e05b:9763:8b5e:3790) |
| 23:24.06 | *** mode/#asterisk-dev [+o leedm777] by ChanServ |
| 23:43.11 | *** join/#asterisk-dev joshelson (~joshelson@2601:282:782:4b79:2d2e:57e8:f2b8:98a4) |