| 01:15.59 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 03:13.07 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 06:41.11 | *** join/#asterisk-dev tsearle (~tsearle@37.19.10.33) |
| 06:41.12 | *** mode/#asterisk-dev [+o tsearle] by ChanServ |
| 06:49.51 | *** join/#asterisk-dev CELYA_ (~Thunderbi@LStLambert-657-1-90-73.w80-13.abo.wanadoo.fr) |
| 07:03.49 | *** join/#asterisk-dev pchero_work (~pchero@109.70.54.56) |
| 07:07.55 | *** join/#asterisk-dev hehol (~hehol@gatekeeper.loca.net) |
| 08:34.27 | *** join/#asterisk-dev jkroon (~jkroon@vc-nat-gp-n-41-13-104-119.umts.vodacom.co.za) |
| 10:08.14 | *** join/#asterisk-dev AsteriskRoss (259d3426@gateway/web/freenode/ip.37.157.52.38) |
| 13:37.17 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 13:49.23 | *** join/#asterisk-dev bford (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 13:49.41 | *** mode/#asterisk-dev [+o bford] by ChanServ |
| 14:43.11 | NirS | good morning all |
| 14:47.13 | coreyfarrell | I know I just posted it last night but is anyone willing to review https://gerrit.asterisk.org/6845 (testsuite memcheck-delay-stop)? I want to work on tests that are leaking due to SIP timers but don't want to modify a hundred tests then have someone tell me to change how the memcheck-delay-stop is configured. |
| 14:48.21 | *** join/#asterisk-dev rmudgett (rmudgett@nat/digium/x-maprkrtdjuawxego) |
| 14:48.22 | *** mode/#asterisk-dev [+o rmudgett] by ChanServ |
| 14:48.28 | NirS | sorry, seems like that is a bit higher than current pay grade (aka: I have no idea what that is and dinner time is about to start) |
| 14:50.22 | coreyfarrell | NirS: don't worry someone who knows the testsuite will look at it :) |
| 14:51.54 | NirS | I know, I'm kidding |
| 14:56.44 | *** join/#asterisk-dev tuxd00d (~tuxd00d@ip68-106-11-138.ph.ph.cox.net) |
| 15:49.47 | *** join/#asterisk-dev bford_ (d8cff501@gateway/web/freenode/ip.216.207.245.1) |
| 15:49.47 | *** mode/#asterisk-dev [+o bford_] by ChanServ |
| 15:57.15 | *** join/#asterisk-dev tuxd00d (~tuxd00d@wsip-98-190-134-84.ph.ph.cox.net) |
| 17:26.17 | *** join/#asterisk-dev jkroon (~jkroon@165.16.204.165) |
| 17:32.29 | *** join/#asterisk-dev pc-m (~pcm@modemcable094.94-70-69.static.videotron.ca) |
| 17:40.38 | coreyfarrell | in res_pjsip_pubsub.c:pubsub_on_rx_subscribe_request() there is a comment: Since this is a normal subscribe, pjproject takes care of the timer |
| 17:41.55 | coreyfarrell | how can I find more about that timer - what callback it uses & how long before timeout? |
| 17:43.14 | file | it'd be in the PJSIP evsub |
| 17:47.05 | rmudgett | That is the subscription expire timer. When we recreate the subscription from a restart we have to explicitly start the timer in res_pjsip_pubsub.c:initial_notify_task() |
| 19:41.23 | *** join/#asterisk-dev cresl1n (Adium@asterisk/libpri-and-libss7-expert/Cresl1n) |
| 19:41.23 | *** mode/#asterisk-dev [+o cresl1n] by ChanServ |
| 20:47.19 | cresl1n | Ok, so I haven't done much work in the deep dark reaches of stasis |
| 20:47.26 | cresl1n | (to preset my question) |
| 20:48.11 | cresl1n | how can a message be set to hint_change_message_type |
| 20:48.41 | file | by creating a message with that type? |
| 20:48.57 | cresl1n | I'm probably doing something dumb here |
| 20:49.04 | seanbright | probs |
| 20:49.19 | cresl1n | Awww crap |
| 20:49.20 | cresl1n | just saw it |
| 20:49.25 | seanbright | is knee deep in learning ffmpeg. can't help. |
| 20:49.30 | file | seanbright: RUN AWAY |
| 20:49.41 | cresl1n | seanbright: Are we talking an MCU in asterisk's future? |
| 20:49.42 | cresl1n | :-P |
| 20:49.50 | seanbright | god no |
| 20:49.53 | file | no, there was silliness in #asterisk |
| 20:49.57 | seanbright | well, not from my anyway |
| 20:50.00 | cresl1n | Finally found it |
| 20:50.03 | cresl1n | how did I miss it |
| 20:50.12 | cresl1n | publish_hint_change creates messages of hint_change_message_type |
| 20:52.47 | file | yup |
| 20:58.13 | coreyfarrell | I think I finally untangled the pjsip subscription tree reference leak. sub_tree->root->tree == sub_tree and it held a reference that was never released. |
| 20:59.44 | coreyfarrell | remains to be seen if my fix is reasonable/correct, but posted for review anyways. I was testing with tests/channels/pjsip/subscriptions/rls/lists/nominal/presence/initial_notify - any other specific tests I should try? |
| 21:00.59 | coreyfarrell | I have to modify the tests to use a shorter 'Expires:' header in the SUBSCRIBE request and add a shutdown delay so I can't just run all the tests. |