00:30.30 | *** join/#asterisk-bugs elguero (~miguel323@17.140.211.66.inaddr.G4.NET) |
00:53.02 | *** join/#asterisk-bugs seraphie (~erin@207.98.195.107) |
01:33.17 | *** join/#asterisk-bugs elguero (~miguel323@17.140.211.66.inaddr.G4.NET) |
01:53.11 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
01:53.11 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
04:52.44 | *** join/#asterisk-bugs Juggie (~Juggie@unaffiliated/juggie) |
04:52.44 | *** mode/#asterisk-bugs [+o Juggie] by ChanServ |
07:09.18 | *** join/#asterisk-bugs tzafrir (~tzafrir@local.xorcom.com) |
12:24.20 | *** join/#asterisk-bugs i_eat_children (~i_eat_chi@firewall-a.buf.ny.i-evolve.net) |
12:33.12 | Entomologist | *** CLOSED (19285) [Channels/General] Asterisk 1.8 dead with 100% CPU |
12:33.13 | Entomologist | Reported by: satish_lx |
12:33.13 | Entomologist | https://issues.asterisk.org/view.php?id=19285 |
12:33.14 | Entomologist | ********************************************************* |
12:39.40 | Entomologist | *** CLOSED (18896) [Utilities/General] [patch] debian init script not lsb compliant |
12:39.41 | Entomologist | Reported by: manwe |
12:39.41 | Entomologist | https://issues.asterisk.org/view.php?id=18896 |
12:39.42 | Entomologist | ********************************************************* |
12:41.00 | leifmadsen | seanbright: ping? |
12:41.05 | leifmadsen | M18891 |
12:41.07 | MuffinMan | [ready for testing] [Asterisk] Applications/app_voicemail 0018891: [patch] app_voicemail creates "general" mailbox from users.conf reported by pdugas https://issues.asterisk.org/view.php?id=18891 |
12:41.12 | leifmadsen | just looking for a review of a 2 line patch |
12:41.45 | seanbright | looks |
12:42.19 | seanbright | eh |
12:42.53 | seanbright | leifmadsen: regardless of the merits of the patch - is his description of the desired behavior correct? |
12:43.08 | seanbright | in other words - should we be skipping [general]? |
12:43.17 | leifmadsen | I think so yes |
12:43.22 | leifmadsen | I've seen it too |
12:43.39 | seanbright | ok, then it's good, except i would negate the conditional and just continue |
12:43.41 | leifmadsen | basically it creates a blank [general] voicemail context |
12:43.46 | seanbright | if (!strcasecmp(cat, "general")) |
12:43.50 | seanbright | <PROTECTED> |
12:43.57 | seanbright | with braces and such |
12:44.17 | Marquis42 | Yes, that would be preferred. That would also fix the formatting issue with the patch. |
12:44.22 | seanbright | indeed. |
12:44.27 | seanbright | i'm awesome like that. |
12:44.30 | leifmadsen | someone want to provide the updated patch? :) |
12:44.31 | Marquis42 | :) |
12:44.39 | leifmadsen | if not I can have a shot at it |
12:44.46 | seanbright | ok, i can |
12:44.58 | leifmadsen | don't do more work than is necessary (is my motto) |
12:45.14 | seanbright | which versions does it affect? |
12:45.17 | Marquis42 | seanbright beat me to it, I was going to offer. But feel free! :) |
12:45.19 | seanbright | besides trunk, obviously |
12:45.23 | leifmadsen | agreed |
12:45.37 | leifmadsen | well... could almost be 1.8 because I consider that a bug, not a feature |
12:45.58 | leifmadsen | but it could potentially break existing systems, so ya, trunk with a note in CHANGES |
12:46.07 | seanbright | i'll let you do the note |
12:46.09 | Marquis42 | Yes, at least 1.8 I think. |
12:46.13 | leifmadsen | seanbright: perfect |
12:46.21 | leifmadsen | Marquis42: well 1.8 is the earliest we patch now :) |
12:46.57 | Marquis42 | leifmadsen: True, true. I keep forgetting that. |
12:47.09 | leifmadsen | yep, don't do more work than is necessary! |
12:47.15 | Marquis42 | Indeed |
12:47.18 | leifmadsen | :) |
12:47.27 | seanbright | leifmadsen: attached |
12:47.58 | leifmadsen | I tagged 1.4.42-rc1 yesterday, just waiting on tarball signage and review of the release announcement. That should go out in a couple of hours. Only a couple more issues to resolve today i think, then 1.6.2.19-rc1 and 1.8.5-rc1 will get tagged too |
12:48.02 | leifmadsen | seanbright: rock on with your bad self |
12:48.15 | leifmadsen | so.... trunk forward? |
12:48.30 | seanbright | eh? |
12:48.39 | leifmadsen | sorry, I meant, "commit to trunk only? |
12:48.43 | leifmadsen | or 1.8 forward? |
12:48.44 | seanbright | that's your call |
12:48.47 | leifmadsen | fair enough |
12:48.55 | seanbright | seems like a bug |
12:48.57 | seanbright | but who knows |
12:49.01 | leifmadsen | ya that's what I'm thinking too |
12:49.11 | leifmadsen | I'm going to apply to 1.8 forward |
12:49.22 | leifmadsen | I'm being daring today with russellb away |
12:49.36 | leifmadsen | waits for the ghost of russellb to chime in |
12:53.52 | Entomologist | *** CLOSED (18891) [Applications/app_voicemail] [patch] app_voicemail creates "general" mailbox from users.conf |
12:53.52 | Entomologist | Reported by: pdugas |
12:53.53 | Entomologist | https://issues.asterisk.org/view.php?id=18891 |
12:53.54 | Entomologist | ********************************************************* |
12:56.11 | leifmadsen | thanks all! |
12:57.29 | seanbright | sure |
12:57.43 | seanbright | that was like a living breathing how-many-blondes joke |
12:57.55 | leifmadsen | w00t |
13:58.32 | *** join/#asterisk-bugs putnopvut (~putnopvut@asterisk/master-of-queues/mmichelson) |
13:58.32 | *** mode/#asterisk-bugs [+o putnopvut] by ChanServ |
14:05.44 | *** join/#asterisk-bugs malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
14:05.44 | *** mode/#asterisk-bugs [+o malcolmd] by ChanServ |
14:12.58 | *** join/#asterisk-bugs elguero (~miguel323@17.140.211.66.inaddr.G4.NET) |
14:20.33 | *** join/#asterisk-bugs The_Boy_Wonder (~vossel@asterisk/batman-developer/dvossel) |
14:38.12 | Entomologist | *** CLOSED (19293) [Core/CallCompletionSupplementaryServices] [patch] CCSS Crash introduced in new SVN [318867] |
14:38.13 | Entomologist | Assigned to: lmadsen |
14:38.14 | Entomologist | Reported by: irroot |
14:38.14 | Entomologist | https://issues.asterisk.org/view.php?id=19293 |
14:38.14 | Entomologist | ********************************************************* |
14:38.49 | leifmadsen | Corydon76-home: ping? |
14:38.59 | leifmadsen | is there a dialplan function that replaces full strings of text? |
14:39.32 | leifmadsen | REPLACE() just does single chars |
14:43.05 | *** join/#asterisk-bugs tzafrir (~tzafrir@local.xorcom.com) |
15:06.31 | Marquis42 | leifmadsen: What do you mean by that? i.e., example |
15:09.41 | leifmadsen | [Syntax] |
15:09.41 | leifmadsen | REPLACE(varname,find-chars[,replace-char]) |
15:10.09 | leifmadsen | so instead of replacing chars, you would say something like: REPLACE_STRING(varname,word,replace-word) |
15:10.14 | leifmadsen | JonathanRose: is that right? |
15:13.10 | Marquis42 | Ah, so you're looking for substring replacement. I'm not aware of such a function. |
15:13.22 | leifmadsen | Marquis42: ya same here |
15:14.12 | Marquis42 | It would be really cool if we could use full regex replacements. I would like that. |
15:14.38 | leifmadsen | indeed |
15:21.02 | Marquis42 | wonders how hard it would be build one using PCRE... |
15:24.27 | JonathanRose | [Synopsis] |
15:24.28 | JonathanRose | Replace instances of a substring within a string with another string. |
15:24.28 | JonathanRose | [Description] |
15:24.28 | JonathanRose | Searches <string> for all instances of the <find-string> and replaces them |
15:24.28 | JonathanRose | with <replace-string>. If <replace-string> is an empty string, this will |
15:24.28 | JonathanRose | effecively delete that substring. If <max-replacements> is specified, this |
15:24.30 | JonathanRose | function will stop after performing replacements <max-replacements> times. |
15:24.32 | JonathanRose | NOTE: The replacement only occurs in the output. The original variable is |
15:24.34 | JonathanRose | not altered. |
15:24.38 | JonathanRose | [Syntax] |
15:24.40 | JonathanRose | STRREPLACE(string,find-string[,replace-string[,max-replacements]]) |
15:24.42 | JonathanRose | [Arguments] |
15:24.44 | JonathanRose | Not available |
15:24.46 | JonathanRose | [See Also] |
15:24.49 | JonathanRose | Not available |
15:24.51 | JonathanRose | If you want to put it into a variable, you'd use something like... |
15:25.07 | JonathanRose | SET(VARNAME=${STRREPLACE(...)}) |
15:25.36 | Marquis42 | JonathanRose: Is this an existing function or one you're proposing? |
15:25.42 | leifmadsen | one he's writing |
15:25.45 | JonathanRose | One I've been assigned to write. |
15:25.46 | Marquis42 | Ah, ok. |
15:26.06 | JonathanRose | Not quite sure why we are talking about this in #asterisk-bugs |
15:26.13 | leifmadsen | :) |
15:26.16 | leifmadsen | I started in the wrong channel |
15:26.26 | Marquis42 | Yeah, what's the related issue #? :P |
15:26.59 | JonathanRose | https://issues.asterisk.org/view.php?id=18023 |
15:27.14 | Marquis42 | Well then there you go, now it fits. :) |
15:27.35 | JonathanRose | There was a patch submitted for it, but it was a little wonky |
15:27.49 | JonathanRose | And it doesn't fit, because it wasn't a bug. |
15:27.53 | JonathanRose | It was a feature submission. |
15:30.08 | Marquis42 | Hey, I'm trying to justify leifmadsen's bringing it up in this channel. Don't cloud the issue with facts! ;) |
16:37.23 | *** join/#asterisk-bugs elguero (~miguel323@17.140.211.66.inaddr.G4.NET) |
16:46.06 | Corydon76-home | JonathanRose: what happens if the input string contains commas? |
16:56.06 | JonathanRose | Hmm, I should check. |
16:56.14 | JonathanRose | Might make it explode. |
16:56.33 | Corydon76-home | JonathanRose: or quotation marks? |
16:57.11 | JonathanRose | I don't think it'd be a problem with the function itself though so much as the way arguments are read into functions. I think they might be able to be escaped. |
16:57.41 | Corydon76-home | JonathanRose: consider any amount of possibly dangerous input. Now consider there's a good reason to specify the input string as a variable name instead of a value |
16:58.42 | JonathanRose | commas work fine as long as they are in quotes. |
16:58.59 | JonathanRose | I'll add a test case though. |
16:59.12 | JonathanRose | When I say in quotes, I mean the whole string is in quotes. |
16:59.17 | JonathanRose | And commas are contained in the string. |
16:59.26 | JonathanRose | Without quotes, they act as a delimiter of course. |
16:59.29 | Corydon76-home | JonathanRose: and if the input contains quote characters? |
16:59.54 | JonathanRose | Working on it. |
17:00.40 | Corydon76-home | There are security issues with what you're doing. Please make the first argument a variable name instead of a value. |
17:02.19 | JonathanRose | I don't see how that's a security issue. |
17:02.34 | Corydon76-home | Think remotely specified strings. |
17:02.52 | Corydon76-home | Think Caller*ID |
17:03.21 | JonathanRose | You'll have to explain it to me. |
17:05.08 | Corydon76-home | Okay, you're dealing with SIP remote strings, where a caller can specify any arbitrary string. If you use that directly in your argument string, the remote caller (attacker) can affect the way that your function works. |
17:05.53 | Corydon76-home | Instead, you want to ensure that any arbitrary string that the remote user sends cannot affect parsing. |
17:06.09 | *** join/#asterisk-bugs malcolmd (~malcolmd@pdpc/sponsor/digium/malcolmd) |
17:06.10 | *** mode/#asterisk-bugs [+o malcolmd] by ChanServ |
17:07.05 | Corydon76-home | That's why there's any number of functions that work on a variable name, instead of allowing the string to be specified directly in the arguments. |
17:07.24 | Corydon76-home | I know you think it's inconvenient, but there's a good reason (security) for doing it. |
17:08.06 | JonathanRose | It seems to me like the operator can do that though. |
17:08.20 | Corydon76-home | How does the operator do that? |
17:08.25 | JonathanRose | Simply by specifying the input string as the variable |
17:08.30 | JonathanRose | Like ${varname} |
17:09.00 | Corydon76-home | Yes, but the substitution occurs prior to the application getting the arguments |
17:09.37 | JonathanRose | I thought the arguments came from string in the dialplan, not from the SIP message. |
17:09.49 | JonathanRose | Rather |
17:09.54 | JonathanRose | it seems rather SIP agnostic in general. |
17:10.13 | JonathanRose | I don't really see any substitution occuring. |
17:10.25 | Corydon76-home | Correct, but the variable that you're specifying may be something like ${CALLERID(name)}. If you specify that as CALLERID(name) as the first argument, the application can isolate the value. |
17:11.36 | Corydon76-home | Caller*ID is the simple case. In some cases, the admin will be messing with various SIPHEADER values. |
17:12.38 | Corydon76-home | We can't just say "the admin should be aware of those problems". We have to make it safe in the general case. |
17:13.01 | JonathanRose | If you say so. |
17:13.34 | Corydon76-home | I've been doing this a long time. ;-) |
17:45.43 | JonathanRose | Corydon76-home: Since that's the way things are going, should I be turning the search and replace strings into variables as well? Seems to me like if you have this problem with any of them, you have it with all of them. |
18:06.08 | Corydon76-home | JonathanRose: Those strings generally aren't specified remotely, though |
18:20.18 | JonathanRose | They could be though. |
18:21.24 | Corydon76-home | What's the use case for a remotely specified search or replace string? |
18:22.35 | Corydon76-home | Caller*ID subject string is the use case for that argument. |
18:32.05 | JonathanRose | Maybe you want to make some string swap a placeholder name with the caller id name? |
18:32.31 | JonathanRose | I don't know man. Security in general is a rather opaque subject for me. |
18:55.25 | Corydon76-home | JonathanRose: that's why the review process exists |
19:16.32 | JonathanRose | *Oi, rewriting the tests to work with a dummy channel so that I could store variables for the purpose of this change did a number on my brain. |
20:13.13 | Entomologist | *** CLOSED (19221) [NewFeature] Option needed for IE_TIME_DATE to be optional on connect |
20:13.14 | Entomologist | Reported by: kenner |
20:13.14 | Entomologist | https://issues.asterisk.org/view.php?id=19221 |
20:13.15 | Entomologist | ********************************************************* |
21:14.11 | *** join/#asterisk-bugs tzafrir (~tzafrir@bzq-218-155-148.cablep.bezeqint.net) |
21:57.13 | Entomologist | *** CLOSED (19204) [General] Asterisk 1.6.0.22 crash |
21:57.14 | Entomologist | Reported by: philippebolduc |
21:57.14 | Entomologist | https://issues.asterisk.org/view.php?id=19204 |
21:57.15 | Entomologist | ********************************************************* |
22:19.36 | *** join/#asterisk-bugs tzafrir (~tzafrir@bzq-218-155-146.cablep.bezeqint.net) |
23:03.35 | *** join/#asterisk-bugs leifmadsen (~Leif@asterisk/documenteur-extraordinaire/blitzrage) |
23:03.35 | *** mode/#asterisk-bugs [+o leifmadsen] by ChanServ |
23:38.24 | *** join/#asterisk-bugs tzafrir_laptop (~tzafrir@212.179.75.202) |